tris/recoll
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: a naming reuse

Browse Source 
At ~200 lines below, `it` get reused and shadowed in a for loop `QStringList::iterator it`.

Eliminate it completely. If we use C++20, we can just std::set::contains()
This commit is contained in:
shenleban tongying 2022-08-23 04:57:21 -04:00
parent bed57aeaf6
commit 565a1115f7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qtgui/preview_w.cpp
View File

@ -782,8 +782,9 @@ bool Preview::loadDocInCurrentTab(const Rcl::Doc &idoc, int docnum)
connect(&lthr, SIGNAL(finished()), &loop, SLOT(quit())); connect(&lthr, SIGNAL(finished()), &loop, SLOT(quit()));
bool canGetRawText = rcldb && rcldb->storesDocText(); bool canGetRawText = rcldb && rcldb->storesDocText();
auto it = prefs.preferStoredTextMimes.find(idoc.mimetype); bool preferStoredText = std::find(prefs.preferStoredTextMimes.begin(),
bool preferStoredText = (it != prefs.preferStoredTextMimes.end()); prefs.preferStoredTextMimes.end(),
idoc.mimetype) != prefs.preferStoredTextMimes.end();
bool loadok{false}; bool loadok{false};
if (!preferStoredText || !canGetRawText) { if (!preferStoredText || !canGetRawText) {