From 565a1115f7475c1283a1b88daba6201a2c1559c2 Mon Sep 17 00:00:00 2001
From: shenleban tongying <shenlebantongying@gmail.com>
Date: Tue, 23 Aug 2022 04:57:21 -0400
Subject: [PATCH] fix: a naming reuse

At ~200 lines below, `it` get reused and shadowed in a for loop `QStringList::iterator it`.

Eliminate it completely. If we use C++20, we can just std::set::contains()
---
 src/qtgui/preview_w.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/qtgui/preview_w.cpp b/src/qtgui/preview_w.cpp
index 43d1e080..1d0d00c9 100644
--- a/src/qtgui/preview_w.cpp
+++ b/src/qtgui/preview_w.cpp
@@ -782,8 +782,9 @@ bool Preview::loadDocInCurrentTab(const Rcl::Doc &idoc, int docnum)
     connect(&lthr, SIGNAL(finished()), &loop, SLOT(quit()));
 
     bool canGetRawText = rcldb && rcldb->storesDocText();
-    auto it = prefs.preferStoredTextMimes.find(idoc.mimetype);
-    bool preferStoredText = (it != prefs.preferStoredTextMimes.end());
+    bool preferStoredText = std::find(prefs.preferStoredTextMimes.begin(),
+                                      prefs.preferStoredTextMimes.end(),
+                                      idoc.mimetype) != prefs.preferStoredTextMimes.end();
     bool loadok{false};
 
     if (!preferStoredText || !canGetRawText) {