From b3af8200d6e59044a196185d2a2f4dcb8118de9b Mon Sep 17 00:00:00 2001 From: Jean-Francois Dockes Date: Sun, 17 Apr 2016 17:04:03 +0200 Subject: [PATCH] Restoring adv search clause list bigger than default size could/would crash the GUI --- src/qtgui/advsearch_w.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qtgui/advsearch_w.cpp b/src/qtgui/advsearch_w.cpp index 712d191f..c3cb6834 100644 --- a/src/qtgui/advsearch_w.cpp +++ b/src/qtgui/advsearch_w.cpp @@ -91,13 +91,13 @@ void AdvSearch::init() // Tune initial state according to last saved { vector::iterator cit = m_clauseWins.begin(); - for (vector::iterator it = prefs.advSearchClauses.begin(); - it != prefs.advSearchClauses.end(); it++) { - if (cit != m_clauseWins.end()) { - (*cit)->tpChange(*it); + unsigned int existing = m_clauseWins.size(); + for (unsigned int i = 0; i < prefs.advSearchClauses.size(); i++) { + if (i < existing) { + (*cit)->tpChange(prefs.advSearchClauses[i]); cit++; } else { - addClause(*it); + addClause(prefs.advSearchClauses[i]); } } }