tris/recoll
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

When copying a file path from the result list to the clipboard, replace the implicit conversion from latin1 with fromLocal8Bit(), which is not guaranteed to make sense but will probably work in more cases

Browse Source
This commit is contained in:
Jean-Francois Dockes 2010-10-29 19:44:17 +02:00
parent 51b171d0e7
commit 825c9d9cf7
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/qtgui/reslist.cpp
View File

@ -708,11 +708,17 @@ void ResList::menuCopyFN()
Rcl::Doc doc;
if (getDoc(m_popDoc, doc)) {
LOGDEB(("menuCopyFN: Got doc, fn: [%s]\n", doc.url.c_str()));
// Our urls currently always begin with "file://"
QApplication::clipboard()->setText(doc.url.c_str()+7,
QClipboard::Selection);
QApplication::clipboard()->setText(doc.url.c_str()+7,
QClipboard::Clipboard);
// Our urls currently always begin with "file://"
//
// Problem: setText expects a QString. Passing a (const char*)
// as we used to do causes an implicit conversion from
// latin1. File are binary and the right approach would be no
// conversion, but it's probably better (less worse...) to
// make a "best effort" tentative and try to convert from the
// locale's charset than accept the default conversion.
QString qfn = QString::fromLocal8Bit(doc.url.c_str()+7);
QApplication::clipboard()->setText(qfn, QClipboard::Selection);
QApplication::clipboard()->setText(qfn, QClipboard::Clipboard);
}
}
void ResList::menuCopyURL()