tris/recoll
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Indicate log location in some indexer error messages which will be displayed in the GUI

Browse Source
This commit is contained in:
Jean-Francois Dockes 2020-11-19 11:16:51 +01:00
parent 3e72a11932
commit 8111320a22
2 changed files with 58 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/index/indexer.cpp
View File

@ -156,6 +156,13 @@ bool ConfIndexer::index(bool resetbefore, ixType typestorun, int flags)
addIdxReason("indexer", m_db.getReason()); addIdxReason("indexer", m_db.getReason());
return false; return false;
} }
std::string logloc;
if (Logger::getTheLog()->logisstderr()) {
logloc = "program error output.";
} else {
logloc = std::string(" log in ") +
Logger::getTheLog()->getlogfilename() + ".";
}
m_config->setKeyDir(cstr_null); m_config->setKeyDir(cstr_null);
if (typestorun & IxTFs) { if (typestorun & IxTFs) {
@ -168,7 +175,7 @@ bool ConfIndexer::index(bool resetbefore, ixType typestorun, int flags)
if (stopindexing) { if (stopindexing) {
addIdxReason("indexer", "Indexing was interrupted."); addIdxReason("indexer", "Indexing was interrupted.");
} else { } else {
addIdxReason("indexer", "Index creation failed. See log."); addIdxReason("indexer", "Index creation failed. See" + logloc);
} }
m_db.close(); m_db.close();
return false; return false;
@ -181,7 +188,7 @@ bool ConfIndexer::index(bool resetbefore, ixType typestorun, int flags)
m_webindexer = new WebQueueIndexer(m_config, &m_db, m_updater); m_webindexer = new WebQueueIndexer(m_config, &m_db, m_updater);
if (!m_webindexer || !m_webindexer->index()) { if (!m_webindexer || !m_webindexer->index()) {
m_db.close(); m_db.close();
addIdxReason("indexer", "Web index creation failed. See log"); addIdxReason("indexer", "Web index creation failed. See" + logloc);
return false; return false;
} }
} }
@ -191,7 +198,7 @@ bool ConfIndexer::index(bool resetbefore, ixType typestorun, int flags)
// filesystem anymore. Only if all *configured* indexers ran. // filesystem anymore. Only if all *configured* indexers ran.
if (m_updater && !m_updater->update(DbIxStatus::DBIXS_PURGE, "")) { if (m_updater && !m_updater->update(DbIxStatus::DBIXS_PURGE, "")) {
m_db.close(); m_db.close();
addIdxReason("indexer", "Index purge failed. See log"); addIdxReason("indexer", "Index purge failed. See" + logloc);
return false; return false;
} }
m_db.purge(); m_db.purge();
@ -205,7 +212,7 @@ bool ConfIndexer::index(bool resetbefore, ixType typestorun, int flags)
if (!m_db.close()) { if (!m_db.close()) {
LOGERR("ConfIndexer::index: error closing database in " << LOGERR("ConfIndexer::index: error closing database in " <<
m_config->getDbDir() << "\n"); m_config->getDbDir() << "\n");
addIdxReason("indexer", "Index close/flush failed. See log"); addIdxReason("indexer", "Index close/flush failed. See" +logloc);
return false; return false;
} }

8
src/index/recollindex.cpp
View File

@ -397,6 +397,7 @@ static bool checktopdirs(RclConfig *config, vector<string>& nonexist)
} }
} }
bool onegood{false};
for (auto& dir : o_topdirs) { for (auto& dir : o_topdirs) {
dir = path_tildexpand(dir); dir = path_tildexpand(dir);
if (!dir.size() || !path_isabsolute(dir)) { if (!dir.size() || !path_isabsolute(dir)) {
@ -411,6 +412,8 @@ static bool checktopdirs(RclConfig *config, vector<string>& nonexist)
} }
if (!path_exists(dir)) { if (!path_exists(dir)) {
nonexist.push_back(dir); nonexist.push_back(dir);
} else {
onegood = true;
} }
} }
topdirs_state(o_topdirs_emptiness); topdirs_state(o_topdirs_emptiness);
@ -418,7 +421,7 @@ static bool checktopdirs(RclConfig *config, vector<string>& nonexist)
// We'd like to check skippedPaths too, but these are wildcard // We'd like to check skippedPaths too, but these are wildcard
// exprs, so reasonably can't // exprs, so reasonably can't
return true; return onegood;
} }
@ -708,7 +711,8 @@ int main(int argc, char *argv[])
vector<string> nonexist; vector<string> nonexist;
if (!checktopdirs(config, nonexist)) { if (!checktopdirs(config, nonexist)) {
addIdxReason("init", "topdirs not set"); std::cerr << "topdirs not set or only contains invalid paths.\n";
addIdxReason("init", "topdirs not set or only contains invalid paths.");
flushIdxReasons(); flushIdxReasons();
exit(1); exit(1);
} }