From 2b81076348dae923627f2d072b3df6c5af781944 Mon Sep 17 00:00:00 2001
From: Jean-Francois Dockes <jfd@recoll.org>
Date: Thu, 7 Nov 2013 18:24:57 +0100
Subject: [PATCH] python: makedocabstract failure should not cause exception

---
 src/python/recoll/pyrecoll.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/python/recoll/pyrecoll.cpp b/src/python/recoll/pyrecoll.cpp
index c81a8b14..d7489ce7 100644
--- a/src/python/recoll/pyrecoll.cpp
+++ b/src/python/recoll/pyrecoll.cpp
@@ -1248,11 +1248,9 @@ Query_makedocabstract(recoll_QueryObject* self, PyObject *args,PyObject *kwargs)
     }
     string abstract;
     if (hlmethods == 0) {
-	if (!self->query->makeDocAbstract(*(pydoc->doc), abstract)) {
-	    PyErr_SetString(PyExc_EnvironmentError, 
-			    "rcl makeDocAbstract failed");
-	    return 0;
-	}
+        // makeDocAbstract() can fail if there are no query terms (e.g. for
+        // a query like [ext:odt]. This should not cause an exception
+	self->query->makeDocAbstract(*(pydoc->doc), abstract);
     } else {
 	HighlightData hldata;
 	sd->getTerms(hldata);